[ https://issues.apache.org/jira/browse/HBASE-5672?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
chunhui shen updated HBASE-5672: -------------------------------- Attachment: HBASE-5672v2.patch In the patchV2, I add a flag in the thread. Please review again Thanks. > TestLruBlockCache#testBackgroundEvictionThread fails occasionally > ----------------------------------------------------------------- > > Key: HBASE-5672 > URL: https://issues.apache.org/jira/browse/HBASE-5672 > Project: HBase > Issue Type: Bug > Reporter: chunhui shen > Assignee: chunhui shen > Attachments: HBASE-5672.patch, HBASE-5672v2.patch > > > We find TestLruBlockCache#testBackgroundEvictionThread fails occasionally. > I think it's a problem of the test case. > Because runEviction() only do evictionThread.evict(): > {code} > public void evict() { > synchronized(this) { > this.notify(); // FindBugs NN_NAKED_NOTIFY > } > } > {code} > However when we call evictionThread.evict(), the evictionThread may haven't > been in run() in the TestLruBlockCache#testBackgroundEvictionThread. > If we run the test many times, we could find failture easily. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira