daisukebe commented on a change in pull request #40: HBASE-23112 
[hbase-operator-tools] fixMeta in hbck2 is porcelain, in …
URL: 
https://github.com/apache/hbase-operator-tools/pull/40#discussion_r332348658
 
 

 ##########
 File path: hbase-hbck2/README.md
 ##########
 @@ -159,7 +160,9 @@ Command:
 
  fixMeta
    Do a server-side fixing of bad or inconsistent state in hbase:meta.
-   Repairs 'holes' and 'overlaps' in hbase:meta.
+   Critical that hbase:meta is first made healthy before making any
+   other repairs. Fix 'holes', 'overlaps', etc. Is NOT same as the
+   _hbck1_ command named similarily.
    SEE ALSO: reportMissingRegionsInMeta
 
 Review comment:
   > It does not fix holes and overlaps in HDFS -- intentionally.
   
   Ohk, per my reading of the code, 
https://github.com/apache/hbase/blob/branch-2.2/hbase-server/src/main/java/org/apache/hadoop/hbase/master/MetaFixer.java#L83-L108,
 it appears to be creating an empty region in the filesystem and then put the 
entry to meta. I was apparently misunderstanding? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to