BukrosSzabolcs commented on a change in pull request #675: HBASE-23085: Network and Data related Actions URL: https://github.com/apache/hbase/pull/675#discussion_r332379075
########## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/actions/CommandAction.java ########## @@ -0,0 +1,70 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.hadoop.hbase.chaos.actions; + +import java.io.IOException; + +import org.apache.hadoop.hbase.DistributedHBaseCluster; +import org.apache.hadoop.hbase.HBaseCluster; +import org.apache.hadoop.hbase.HBaseClusterManager; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +/** + * Base class for performing Actions based on linux commands requiring sudo privileges + */ +abstract public class CommandAction extends Action { + private static final Logger LOG = LoggerFactory.getLogger(CommandAction.class); + + protected long timeout; + protected HBaseClusterManager clusterManager; + + public CommandAction(long timeout) { + this.timeout = timeout; + } + + @Override + public void init(ActionContext context) throws IOException { + super.init(context); + HBaseCluster cluster = context.getHBaseCluster(); + if(cluster != null && cluster instanceof DistributedHBaseCluster){ + Object manager = ((DistributedHBaseCluster)cluster).getClusterManager(); + if(manager != null && manager instanceof HBaseClusterManager){ + clusterManager = (HBaseClusterManager) manager; + } + } + } + + @Override + public void perform() throws Exception { + if(clusterManager == null){ Review comment: This way if it runs on a non-distributed cluster it just does nothing. It might be better in case someone mixes them with older actions ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
