Apache9 commented on a change in pull request #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible URL: https://github.com/apache/hbase/pull/673#discussion_r332412219
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java ########## @@ -351,11 +350,11 @@ public StoreScanner(ScanInfo scanInfo, ScanType scanType, // Used to instantiate a scanner for compaction in test @VisibleForTesting - StoreScanner(ScanInfo scanInfo, OptionalInt maxVersions, ScanType scanType, + StoreScanner(ScanInfo scanInfo, Integer maxVersions, ScanType scanType, Review comment: Passing value 2 will introduce a Integer.valueOf(2) as you are passing an Integer, not a int. And Optional.empty is just a static object, which does not make any difference with null... ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
