virajjasani commented on a change in pull request #673: HBASE-23093 : Avoid
Optional Anti-Pattern where possible
URL: https://github.com/apache/hbase/pull/673#discussion_r332415264
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/MetricsRegionServerWrapperImpl.java
##########
@@ -275,7 +276,7 @@ public int getFlushQueueSize() {
@Override
public long getBlockCacheCount() {
- return this.blockCache.map(BlockCache::getBlockCount).orElse(0L);
+ return this.blockCache != null ? this.blockCache.getBlockCount() : 0L;
Review comment:
Agree @Apache9 However, Optional.map internall does isPresent() check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
