Apache-HBase commented on issue #673: HBASE-23093 : Avoid Optional Anti-Pattern where possible URL: https://github.com/apache/hbase/pull/673#issuecomment-539565312 :confetti_ball: **+1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | :blue_heart: | reexec | 0m 31s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :green_heart: | test4tests | 0m 0s | The patch appears to include 4 new or modified test files. | ||| _ master Compile Tests _ | | :blue_heart: | mvndep | 1m 0s | Maven dependency ordering for branch | | :green_heart: | mvninstall | 6m 1s | master passed | | :green_heart: | compile | 1m 57s | master passed | | :green_heart: | checkstyle | 2m 36s | master passed | | :green_heart: | shadedjars | 5m 46s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 1m 36s | master passed | | :blue_heart: | spotbugs | 4m 52s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 6m 51s | master passed | ||| _ Patch Compile Tests _ | | :blue_heart: | mvndep | 0m 15s | Maven dependency ordering for patch | | :green_heart: | mvninstall | 6m 29s | the patch passed | | :green_heart: | compile | 1m 55s | the patch passed | | :green_heart: | javac | 1m 55s | the patch passed | | :green_heart: | checkstyle | 0m 37s | hbase-client: The patch generated 0 new + 30 unchanged - 1 fixed = 30 total (was 31) | | :green_heart: | checkstyle | 1m 40s | The patch passed checkstyle in hbase-server | | :green_heart: | checkstyle | 0m 15s | The patch passed checkstyle in hbase-examples | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 5m 17s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 19m 5s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2 or 3.1.2. | | :green_heart: | javadoc | 1m 24s | the patch passed | | :green_heart: | findbugs | 7m 42s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 1m 59s | hbase-client in the patch passed. | | :green_heart: | unit | 164m 17s | hbase-server in the patch passed. | | :green_heart: | unit | 1m 54s | hbase-examples in the patch passed. | | :green_heart: | asflicense | 1m 10s | The patch does not generate ASF License warnings. | | | | 248m 39s | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.2 Server=19.03.2 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/6/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/673 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux 8cfb097407db 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24 10:55:24 UTC 2019 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-673/out/precommit/personality/provided.sh | | git revision | master / e911bb7e21 | | Default Java | 1.8.0_181 | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/6/testReport/ | | Max. process+thread count | 4352 (vs. ulimit of 10000) | | modules | C: hbase-client hbase-server hbase-examples U: . | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-673/6/console | | versions | git=2.11.0 maven=2018-06-17T18:33:14Z) findbugs=3.1.11 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services