[
https://issues.apache.org/jira/browse/HBASE-23133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16947145#comment-16947145
]
Michael Stack commented on HBASE-23133:
---------------------------------------
A few things going on here.
The protobuf compile -- the only place we compile in hbase-thirdparty -- has
not target version on the compile plugin. We need to set it but this does not
'fix' the original complaint in parent. We could get away with NOT requiring
jdk8 at compile time if we set the 'release' target of '8' on the compiler
plugin but jdk8 compiler doesn't know the release flag so would have to be done
in a profile that triggered when jdk9 or greater.
On enforcer, it doesn't fail for me. Let me add patch of the accumulation of
what I was trying.
Putting this aside for now because it burns time running the tests trying
combos.
Here is how to test.
Set java environment to be > jkd8.
Compile hbase-thirdparty.
Go to another environment that is jdk8.
Make sure the pom points at the locally installed hbase-thirdparty (you may
have to mess w/ hbase-thirdparty versions and set the pom.xml in core to pick
it up).
Compile hbase core.
Run mvn test -Dtest=TestProtobufUtil
> hbase-thirdparty create enforcer rule that ensures we build w/ correct jvm
> version
> ----------------------------------------------------------------------------------
>
> Key: HBASE-23133
> URL: https://issues.apache.org/jira/browse/HBASE-23133
> Project: HBase
> Issue Type: Sub-task
> Reporter: Michael Stack
> Priority: Major
>
> See parent. A build of an RC w/ jdk10 though source target is 1.8 doesn't
> work. Add an enforcer to ensure we don't build an RC in this manner again.
> The do-release-docker.sh create-release script rather than the do-release.sh
> should be used building RCs to avoid this kind of issue but for the case
> where it is not used, an enforcer would prevent this problem.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
