Apache9 commented on a change in pull request #673: HBASE-23093 : Avoid
Optional Anti-Pattern where possible
URL: https://github.com/apache/hbase/pull/673#discussion_r333512487
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/StoreScanner.java
##########
@@ -351,11 +350,11 @@ public StoreScanner(ScanInfo scanInfo, ScanType scanType,
// Used to instantiate a scanner for compaction in test
@VisibleForTesting
- StoreScanner(ScanInfo scanInfo, OptionalInt maxVersions, ScanType scanType,
+ StoreScanner(ScanInfo scanInfo, int maxVersions, ScanType scanType,
List<? extends KeyValueScanner> scanners) throws IOException {
// 0 is passed as readpoint because the test bypasses Store
- this(null, maxVersions.isPresent() ? new
Scan().readVersions(maxVersions.getAsInt())
- : SCAN_FOR_COMPACTION, scanInfo, 0, 0L, false, scanType);
+ this(null, maxVersions > 0 ? new Scan().readVersions(maxVersions)
Review comment:
Fine.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
