openinx commented on a change in pull request #678: HBASE-23107 Avoid temp byte
array creation when doing cacheDataOnWrite
URL: https://github.com/apache/hbase/pull/678#discussion_r334310423
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileBlock.java
##########
@@ -1012,6 +1021,18 @@ private void putHeader(byte[] dest, int offset, int
onDiskSize,
Bytes.putInt(dest, offset, onDiskDataSize);
}
+ private void putHeader(ByteBuff buff, int onDiskSize,
Review comment:
Seems we can abstract the two putHeader into a single one ? the byte[]
dest can also be regarded as a ByteBuff ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
