[
https://issues.apache.org/jira/browse/HBASE-5707?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13248625#comment-13248625
]
[email protected] commented on HBASE-5707:
------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4627/#review6750
-----------------------------------------------------------
Looks good to me. I prefer to call it startDate instead of startdate. It is up
to you.
- Jimmy
On 2012-04-03 21:04:54, Michael Stack wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4627/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-03 21:04:54)
bq.
bq.
bq. Review request for hbase.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Move two more znodes to serialize their content as pb.
bq.
bq. Here are the changes:
bq.
bq. {code}
bq. M src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
bq. Get the clusterid via utility in the ClusterId class rather than
bq. get it directly.
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
bq. Serialize and deserialize using new ClusterId pb message.
bq. Include the PBUF preamble on znode content.
bq. M src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
bq. Rename getRootRegionZNodeContent to getZNodeData so it aligns in name
bq. with the other cases where we compose the znode content up in ClusterId
bq. and in ClusterStatusTracker.
bq. M src/main/protobuf/ZooKeeper.proto
bq. Add new messages for ClusterId and ClusterUp
bq. {code}
bq.
bq.
bq. This addresses bug hbase-5707.
bq. https://issues.apache.org/jira/browse/hbase-5707
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/client/HConnectionManager.java
aa30969
bq.
src/main/java/org/apache/hadoop/hbase/protobuf/generated/ZooKeeperProtos.java
8ff87fe
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterId.java 3fa83e6
bq.
src/main/java/org/apache/hadoop/hbase/zookeeper/ClusterStatusTracker.java
61e7367
bq. src/main/java/org/apache/hadoop/hbase/zookeeper/RootRegionTracker.java
6b2ea57
bq. src/main/protobuf/ZooKeeper.proto 20f8eb0
bq.
bq. Diff: https://reviews.apache.org/r/4627/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Michael
bq.
bq.
> Move clusterid and clusterup (shutdown) znodes over to pb
> ---------------------------------------------------------
>
> Key: HBASE-5707
> URL: https://issues.apache.org/jira/browse/HBASE-5707
> Project: HBase
> Issue Type: Task
> Reporter: stack
> Attachments: 5707.txt
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
