Apache-HBase commented on issue #731: HBASE-23185 Fix high cpu usage because getTable()#put() gets config value every time URL: https://github.com/apache/hbase/pull/731#issuecomment-543503094 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |:----:|----------:|--------:|:--------| | :blue_heart: | reexec | 0m 39s | Docker mode activated. | ||| _ Prechecks _ | | :green_heart: | dupname | 0m 0s | No case conflicting files found. | | :green_heart: | hbaseanti | 0m 0s | Patch does not have any anti-patterns. | | :green_heart: | @author | 0m 0s | The patch does not contain any @author tags. | | :yellow_heart: | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. | ||| _ branch-1 Compile Tests _ | | :green_heart: | mvninstall | 10m 12s | branch-1 passed | | :green_heart: | compile | 0m 20s | branch-1 passed with JDK v1.8.0_232 | | :green_heart: | compile | 0m 23s | branch-1 passed with JDK v1.7.0_242 | | :green_heart: | checkstyle | 0m 43s | branch-1 passed | | :green_heart: | shadedjars | 2m 50s | branch has no errors when building our shaded downstream artifacts. | | :green_heart: | javadoc | 0m 28s | branch-1 passed with JDK v1.8.0_232 | | :green_heart: | javadoc | 0m 25s | branch-1 passed with JDK v1.7.0_242 | | :blue_heart: | spotbugs | 1m 31s | Used deprecated FindBugs config; considering switching to SpotBugs. | | :green_heart: | findbugs | 1m 27s | branch-1 passed | ||| _ Patch Compile Tests _ | | :green_heart: | mvninstall | 1m 57s | the patch passed | | :green_heart: | compile | 0m 19s | the patch passed with JDK v1.8.0_232 | | :green_heart: | javac | 0m 19s | the patch passed | | :green_heart: | compile | 0m 23s | the patch passed with JDK v1.7.0_242 | | :green_heart: | javac | 0m 23s | the patch passed | | :broken_heart: | checkstyle | 0m 38s | hbase-client: The patch generated 7 new + 142 unchanged - 1 fixed = 149 total (was 143) | | :green_heart: | whitespace | 0m 0s | The patch has no whitespace issues. | | :green_heart: | shadedjars | 2m 48s | patch has no errors when building our shaded downstream artifacts. | | :green_heart: | hadoopcheck | 5m 3s | Patch does not cause any errors with Hadoop 2.8.5 2.9.2. | | :green_heart: | javadoc | 0m 20s | the patch passed with JDK v1.8.0_232 | | :green_heart: | javadoc | 0m 25s | the patch passed with JDK v1.7.0_242 | | :green_heart: | findbugs | 1m 31s | the patch passed | ||| _ Other Tests _ | | :green_heart: | unit | 2m 38s | hbase-client in the patch passed. | | :green_heart: | asflicense | 0m 18s | The patch does not generate ASF License warnings. | | | | 37m 28s | | | Subsystem | Report/Notes | |----------:|:-------------| | Docker | Client=19.03.3 Server=19.03.3 base: https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/Dockerfile | | GITHUB PR | https://github.com/apache/hbase/pull/731 | | Optional Tests | dupname asflicense javac javadoc unit spotbugs findbugs shadedjars hadoopcheck hbaseanti checkstyle compile | | uname | Linux ba66d440b7da 4.15.0-60-generic #67-Ubuntu SMP Thu Aug 22 16:55:30 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux | | Build tool | maven | | Personality | /home/jenkins/jenkins-slave/workspace/HBase-PreCommit-GitHub-PR_PR-731/out/precommit/personality/provided.sh | | git revision | branch-1 / 425d84d | | Default Java | 1.7.0_242 | | Multi-JDK versions | /usr/lib/jvm/zulu-8-amd64:1.8.0_232 /usr/lib/jvm/zulu-7-amd64:1.7.0_242 | | checkstyle | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/artifact/out/diff-checkstyle-hbase-client.txt | | Test Results | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/testReport/ | | Max. process+thread count | 148 (vs. ulimit of 10000) | | modules | C: hbase-client U: hbase-client | | Console output | https://builds.apache.org/job/HBase-PreCommit-GitHub-PR/job/PR-731/1/console | | versions | git=1.9.1 maven=3.0.5 findbugs=3.0.1 | | Powered by | Apache Yetus 0.11.0 https://yetus.apache.org | This message was automatically generated.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services