saintstack commented on a change in pull request #739: HBASE-23157 WAL
unflushed seqId tracking may wrong when Durability.AS…
URL: https://github.com/apache/hbase/pull/739#discussion_r337664460
##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WAL.java
##########
@@ -98,43 +98,41 @@
/**
* Append a set of edits to the WAL. The WAL is not flushed/sync'd after
this transaction
- * completes BUT on return this edit must have its region edit/sequence id
assigned
- * else it messes up our unification of mvcc and sequenceid. On return
<code>key</code> will
- * have the region edit/sequence id filled in.
+ * completes BUT on return this edit must have its region edit/sequence id
assigned else it messes
+ * up our unification of mvcc and sequenceid. On return <code>key</code>
will have the region
+ * edit/sequence id filled in.
* @param info the regioninfo associated with append
* @param key Modified by this call; we add to it this edits region
edit/sequence id.
* @param edits Edits to append. MAY CONTAIN NO EDITS for case where we want
to get an edit
- * sequence id that is after all currently appended edits.
- * @param inMemstore Always true except for case where we are writing a
compaction completion
- * record into the WAL; in this case the entry is just so we can finish an
unfinished compaction
- * -- it is not an edit for memstore.
+ * sequence id that is after all currently appended edits.
+ * @param inMemstore Always true except for case where we are writing a
region event marker, for
+ * example, a compaction completion record into the WAL; in this
case the entry is just
+ * so we can finish an unfinished compaction -- it is not an edit
for memstore.
+ * @param closeRegion Whether this is a region close marker, i.e, the last
wal edit for this
+ * region on this region server. The WAL implementation should
remove all the related
+ * stuff, for example, the sequence id accounting.
Review comment:
Good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
