bharathv commented on a change in pull request #773: HBASE-23212 : Dynamically reload configs for Region Recovery chore URL: https://github.com/apache/hbase/pull/773#discussion_r340866282
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/RegionsRecoveryChore.java ########## @@ -171,4 +167,20 @@ private void prepareTableToReopenRegionsMap( } + // hashcode/equals implementation to ensure at-most one object of RegionsRecoveryChore Review comment: Ya I got that. What I meant was that the behavior is very subtle. Tomorrow if someone wants to have multiple instances of this chore and try submitting them, they get overwritten. Ideally one should get an error saying that only one instance of it should or running or something like that. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
