bharathv commented on a change in pull request #793: HBASE-23255 CLI hbase command prints ERROR when hadoop is set in OS path URL: https://github.com/apache/hbase/pull/793#discussion_r342697311
########## File path: bin/hbase ########## @@ -188,7 +188,7 @@ if [ -d "$HBASE_HOME/hbase-server/target/hbase-webapps" ]; then fi #add the hbase jars for each module -for f in $HBASE_HOME/hbase-jars/hbase*.jar; do +for f in $HBASE_HOME/lib/hbase*.jar; do Review comment: Looks like the commit only fixes the tar-ball version of shell and not a dev build (where the lib/ is not populated). Curious if that was intentional. Fix lgtm otherwise. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services