apurtell commented on a change in pull request #796: HBASE-23251 - Add Column Family and Table Names to HFileContext and u… URL: https://github.com/apache/hbase/pull/796#discussion_r343411903
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/io/hfile/HFileContext.java ########## @@ -63,6 +63,8 @@ private Encryption.Context cryptoContext = Encryption.Context.NONE; private long fileCreateTime; private String hfileName; + private byte[] columnFamily; + private byte[] tableName; Review comment: Nit: I assume its byte[] instead of TableName here because that's what is available in the context. Otherwise TableName offers additional semantics that might be useful in the future, since we're passing it through now. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
