bharathv commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r344334810
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java ########## @@ -163,6 +166,10 @@ public void waitForSplitTransaction(final RegionServerServices services, Region } Thread.sleep(100); spins++; + if (spins > SPLIT_WAIT_TIMEOUT) { Review comment: I'm trying to wrap my head around the state machine here. So this is more of a question, if we throw here and assuming that the master still transitioned the region racily to "SPLITTING", we will still end up rolling back the transaction right? That seems to be the case based on the logic in "doSplitting()", but just wanted to double check. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services