virajjasani commented on a change in pull request #809: HBASE-23261 : Processing ZK BadVersionException during node transition URL: https://github.com/apache/hbase/pull/809#discussion_r344433272
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZKSplitTransactionCoordination.java ########## @@ -40,6 +40,9 @@ private CoordinatedStateManager coordinationManager; private final ZooKeeperWatcher watcher; + // max wait for split transaction - 100 times in a loop with 100 ms of thread sleep each time + private static final int SPLIT_WAIT_TIMEOUT = 100; Review comment: this accounts for ~24 s due to calls involved in loop. even for busy cluster, by this time, we should be able to retry calling setData() to ZK at least ~10 times which I think should be sufficient if ZK node version is changed. In fact, ideally, 2nd retry after failed attempt should be sufficient to retrieve correct ZK node version and successfully updating RIT info in ZK node. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
