[ 
https://issues.apache.org/jira/browse/HBASE-5727?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250028#comment-13250028
 ] 

Nicolas Spiegelberg commented on HBASE-5727:
--------------------------------------------

I agree with Stack, this isn't a common occurrence and is pretty trivial to fix.

getConf() was, sadly, a hack API that was public because one of the tests 
wasn't in the same namespace originally.  It shouldn't have been public because 
the config has traditionally been at a per-server granularity.  Now, with 
HBASE-5335, the per-server config object can be per-server or per-region/per-CF 
depending upon how it's used and the functionality you want.  Now: HRegion.conf 
!= HRegionServer.conf != Store.conf.  If your coprocessor uses the 
HRegionServer.conf, it should work the same as it always has.  If your 
corprocessor uses HRegion.conf, a compilation error is better than a subtle 
runtime error that you have to spend a week hunting down.  Of course, this is 
part of why we tell people they are playing with fire if they use a coprocessor 
(vs. MySQL triggers).

Taking a look at the security code, it looks like you want to use 
HRegionServer.conf because both calling classes seem to access global security 
data.  See HRegionServer.getConfiguration(), which is used in other sections of 
the AccessController class.
                
> secure hbase build broke because of 'HBASE-5451 Switch RPC call 
> envelope/headers to PBs'
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-5727
>                 URL: https://issues.apache.org/jira/browse/HBASE-5727
>             Project: HBase
>          Issue Type: Bug
>            Reporter: stack
>            Assignee: Devaraj Das
>            Priority: Blocker
>             Fix For: 0.96.0
>
>         Attachments: 5727.1.patch, 5727.2.patch, 5727.patch
>
>
> If you build with the security profile -- i.e. add '-P security' on the 
> command line -- you'll see that the secure build is broke since we messed in 
> rpc.
> Assigning Deveraj to take a look.   If you can't work on this now DD, just 
> give it back to me and I'll have a go at it.  Thanks.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to