[
https://issues.apache.org/jira/browse/HBASE-23309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sandeep Pal updated HBASE-23309:
--------------------------------
Description:
ChainWalEntryFilter applies the filter on entry followed by filter on cells.
If filter on cells remove all the cells from the entry, we should't replicate
the entry.
Here is the snippet for ChainWalEntryFilter filter. After filterCells we should
check if there is any cells remaining in the entry.
{code:java}
@Override
public Entry filter(Entry entry) {
for (WALEntryFilter filter : filters) {
if (entry == null) {
return null;
}
entry = filter.filter(entry);
}
filterCells(entry);
return entry;
}{code}
Also, there are not tests for WAlCellFilter, adding test for that as well.
was:
ChainWalEntryFilter applies the filter on entry followed by filter on cells.
If filter on cells remove all the cells from the entry, we should't replicate
the entry.
Here is the snippet for ChainWalEntryFilter filter. After filterCells we should
check if there is any cells remaining in the entry.
{code:java}
@Override
public Entry filter(Entry entry) {
for (WALEntryFilter filter : filters) {
if (entry == null) {
return null;
}
entry = filter.filter(entry);
}
filterCells(entry);
return entry;
}{code}
> Entries get replicated even though all cells get filtered through
> WalCellFilter
> -------------------------------------------------------------------------------
>
> Key: HBASE-23309
> URL: https://issues.apache.org/jira/browse/HBASE-23309
> Project: HBase
> Issue Type: Bug
> Affects Versions: 3.0.0, 1.3.6, 2.3.3
> Reporter: Sandeep Pal
> Assignee: Sandeep Pal
> Priority: Major
>
> ChainWalEntryFilter applies the filter on entry followed by filter on cells.
> If filter on cells remove all the cells from the entry, we should't
> replicate the entry.
> Here is the snippet for ChainWalEntryFilter filter. After filterCells we
> should check if there is any cells remaining in the entry.
> {code:java}
> @Override
> public Entry filter(Entry entry) {
> for (WALEntryFilter filter : filters) {
> if (entry == null) {
> return null;
> }
> entry = filter.filter(entry);
> }
> filterCells(entry);
> return entry;
> }{code}
> Also, there are not tests for WAlCellFilter, adding test for that as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
