[
https://issues.apache.org/jira/browse/HBASE-5684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250415#comment-13250415
]
Phabricator commented on HBASE-5684:
------------------------------------
tedyu has commented on the revision "[jira] [HBASE-5684] Make
ProcessBasedLocalHBaseCluster run HDFS and make it more robust".
Patch looks good.
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/util/HBaseHomePath.java:44 Should read
'to look up'
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:114
Why is sorting needed ?
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:250
I think removing 'to kill' would make the sentence clearer.
src/test/java/org/apache/hadoop/hbase/util/ProcessBasedLocalHBaseCluster.java:395
Should we add mapping for 'fs.defaultFS' as well ?
REVISION DETAIL
https://reviews.facebook.net/D2709
> Make ProcessBasedLocalHBaseCluster run HDFS and make it more robust
> -------------------------------------------------------------------
>
> Key: HBASE-5684
> URL: https://issues.apache.org/jira/browse/HBASE-5684
> Project: HBase
> Issue Type: Improvement
> Reporter: Mikhail Bautin
> Assignee: Mikhail Bautin
> Attachments: D2709.1.patch
>
>
> Currently ProcessBasedLocalHBaseCluster runs on top of raw local filesystem.
> We need it to start a process-based HDFS cluster as well. We also need to
> make the whole thing more stable so we can use it in unit tests.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
