[
https://issues.apache.org/jira/browse/HBASE-5677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13250443#comment-13250443
]
Zhihong Yu commented on HBASE-5677:
-----------------------------------
Some comments about coding style:
{code}
+ //the master is running and it can provide service
+ public boolean isMasterAvailable() {
+ return !isStopped() && isInitialized();
+ }
{code}
@Override is missing for the above method.
Please leave a space between // and the
Indentation for the return line should be 4 spaces. i.e. 'r' of return should
be under 'b' of public.
{code}
+ if(isAvailable) {
{code}
Please leave a space between if and left parenthesis.
{code}
+ throw new MasterNotRunningException();
{code}
You can create a new exception or provide cause to MasterNotRunningException.
> The master never does balance because duplicate openhandled the one region
> --------------------------------------------------------------------------
>
> Key: HBASE-5677
> URL: https://issues.apache.org/jira/browse/HBASE-5677
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.90.6
> Environment: 0.90
> Reporter: xufeng
> Assignee: xufeng
> Attachments: HBASE-5677-90-v1.patch,
> surefire-report_no_patched_v1.html, surefire-report_patched_v1.html
>
>
> If region be assigned When the master is doing initialization(before do
> processFailover),the region will be duplicate openhandled.
> because the unassigned node in zookeeper will be handled again in
> AssignmentManager#processFailover()
> it cause the region in RIT,thus the master never does balance.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
