guangxuCheng commented on a change in pull request #831: HBASE-23297 [RSGROUP] 
build RegionPlan per group not per table
URL: https://github.com/apache/hbase/pull/831#discussion_r348477257
 
 

 ##########
 File path: 
hbase-rsgroup/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupAdminServer.java
 ##########
 @@ -607,6 +613,22 @@ public void removeServers(Set<Address> servers) throws 
IOException {
     return result;
   }
 
+  private Map<ServerName, List<RegionInfo>> getAssignmentsByGroup(String 
groupName)
 
 Review comment:
   Yes, we can balance other groups, but if there are many mis-placed regions, 
we may need to balance many groups, which I think is unreasonable.
   In addition, before the modification, all mis-placed regions of the group 
can be moved to the correct group by balancing the group.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to