wchevreuil commented on a change in pull request #749: HBASE-23205 Correctly 
update the position of WALs currently being replicated
URL: https://github.com/apache/hbase/pull/749#discussion_r352161498
 
 

 ##########
 File path: 
hbase-server/src/test/java/org/apache/hadoop/hbase/replication/regionserver/TestWALEntryStream.java
 ##########
 @@ -378,37 +380,35 @@ public void testReplicationSourceWALReaderThread() 
throws Exception {
   }
 
   @Test
-  public void testReplicationSourceUpdatesLogPositionOnFilteredEntries() 
throws Exception {
+  public void testReplicationSourceWALReaderThreadRecoveredQueue() throws 
Exception {
 
 Review comment:
   Actually yeah, this is indeed simulating recovered queue when creating it as 
recovered. I think this test is fine.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to