[
https://issues.apache.org/jira/browse/HBASE-23355?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985876#comment-16985876
]
chenxu commented on HBASE-23355:
--------------------------------
There also may be a scenario that we don't need cacheOnWrite and
prefetchOnFlush, but prefetchOnRegionOpen is needed.
So how about consider both case?
if (cacheOnWrite || ! prefetchOnFlush) {
// bypass prefetch operations
}
> Add a conf key to decide which operations can trigger prefetch
> --------------------------------------------------------------
>
> Key: HBASE-23355
> URL: https://issues.apache.org/jira/browse/HBASE-23355
> Project: HBase
> Issue Type: Improvement
> Reporter: chenxu
> Assignee: chenxu
> Priority: Major
>
> Copy the comment from anoop under
> https://issues.apache.org/jira/browse/HBASE-23066?focusedCommentId=16984140&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16984140
> {quote}On a side note, (Not related to this issue) when we have cache on
> write ON as well as prefetch also On, do we do the caching part for the
> flushed files twice? When it is written, its already been added to cache.
> Later as part of HFile reader open, the prefetch threads will again do a read
> and add to cache!
> {quote}
> It's better to have a conf key to decide which operations(flush, compaction,
> regionOpen, bulkload) can trigger the prefetch. In this way, if cacheonwrite
> is enabled, we can exclude the flush and compaction operations when doing
> prefetch.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
