[ 
https://issues.apache.org/jira/browse/HBASE-5760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13251040#comment-13251040
 ] 

jirapos...@reviews.apache.org commented on HBASE-5760:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4692/
-----------------------------------------------------------

(Updated 2012-04-10 20:34:07.296907)


Review request for hbase.


Summary
-------

Some of the unit test runs result in files under $hbase_home/test, 
$hbase_home/build, or $hbase_home/. We should ensure that all tests use target 
as their data location.


This addresses bug HBASE-5760.
    https://issues.apache.org/jira/browse/HBASE-5760


Diffs
-----

  src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java 3f239e0 
  
src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java 
32f0cc3 
  
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverInterface.java
 60f21c0 
  
src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
 002d611 
  src/test/java/org/apache/hadoop/hbase/mapreduce/TestHFileOutputFormat.java 
a6bcbac 

Diff: https://reviews.apache.org/r/4692/diff


Testing
-------

Results :

Failed tests:   
testKeyUpdate(org.apache.hadoop.hbase.security.token.TestZKSecretWatcher): 
expected:<AuthenticationKey[ id=2, expiration=9223372036854775807 ]> but 
was:<AuthenticationKey[ id=1, expiration=1334028188780 ]>

Tests in error: 
  
testDelayedRpcImmediateReturnValue(org.apache.hadoop.hbase.ipc.TestDelayedRpc): 
Call to /127.0.0.1:65022 failed on socket timeout exception: 
java.net.SocketTimeoutException: 1000 millis timeout while waiting for channel 
to be ready for read. ch : java.nio.channels.SocketChannel[connected 
local=/127.0.0.1:65039 remote=/127.0.0.1:65022]
  
testTralingGarbageCorruptionFileSkipErrorsPasses(org.apache.hadoop.hbase.regionserver.wal.TestHLogSplit):
 All datanodes 127.0.0.1:52012 are bad. Aborting...
  org.apache.hadoop.hbase.security.access.TestAccessControlFilter: Shutting down
  org.apache.hadoop.hbase.security.access.TestAccessController: Shutting down
  org.apache.hadoop.hbase.security.access.TestTablePermissions: Shutting down
  org.apache.hadoop.hbase.security.access.TestZKPermissionsWatcher: Shutting 
down
  org.apache.hadoop.hbase.security.token.TestTokenAuthentication: Shutting down

Tests run: 900, Failures: 1, Errors: 7, Skipped: 9

I think the ZKSecretWatcher is unrelated. After the tests, there is no residual 
test files lying around. 


Thanks,

enis


                
> Unit tests should write only under /target
> ------------------------------------------
>
>                 Key: HBASE-5760
>                 URL: https://issues.apache.org/jira/browse/HBASE-5760
>             Project: HBase
>          Issue Type: Improvement
>          Components: test
>    Affects Versions: 0.96.0
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>            Priority: Minor
>
> Some of the unit test runs result in files under $hbase_home/test, 
> $hbase_home/build, or $hbase_home/. We should ensure that all tests use 
> target as their data location.  

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to