saintstack commented on a change in pull request #917: HBASE-23383 [hbck2]
`fixHoles` should queue assignment procedures for any regions its fixing
URL: https://github.com/apache/hbase/pull/917#discussion_r355133022
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/assignment/TestAMAssignWithRandExec.java
##########
@@ -44,10 +46,15 @@ public void testAssignWithRandExec() throws Exception {
rsDispatcher.setMockRsExecutor(new RandRsExecutor());
// Loop a bunch of times so we hit various combos of exceptions.
+ int submitCount = 0;
for (int i = 0; i < 10; i++) {
LOG.info("ROUND=" + i);
TransitRegionStateProcedure proc = createAssignProcedure(hri);
- waitOnFuture(submitProcedure(proc));
+ if (proc != null) {
+ waitOnFuture(submitProcedure(proc));
+ submitCount++;
+ }
}
+ assertNotEquals("failed to create any procedures", 0, submitCount);
Review comment:
Good
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
