busbey commented on a change in pull request #916: HBASE-23382: Clean up
Logging for Some of hbase-server Module
URL: https://github.com/apache/hbase/pull/916#discussion_r356401416
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/coordination/ZkSplitLogWorkerCoordination.java
##########
@@ -462,8 +460,10 @@ public void taskLoop() throws InterruptedException {
} catch (KeeperException e) {
LOG.warn("Could not get children of znode " +
watcher.getZNodePaths().splitLogZNode, e);
}
- LOG.debug("Retry listChildren of znode " +
watcher.getZNodePaths().splitLogZNode
- + " after sleep for " + sleepTime + "ms!");
+ if (LOG.isDebugEnabled()) {
+ LOG.debug("Retry listChildren of znode " +
watcher.getZNodePaths().splitLogZNode
Review comment:
use substitution
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
