belugabehr commented on a change in pull request #912: HBASE-23380: General Cleanup of FSUtil URL: https://github.com/apache/hbase/pull/912#discussion_r357274768
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/util/FSUtils.java ########## @@ -546,19 +544,19 @@ public static void setVersion(FileSystem fs, Path rootdir, String version, * @throws IOException if checking the FileSystem fails */ public static boolean checkClusterIdExists(FileSystem fs, Path rootdir, - int wait) throws IOException { + long wait) throws IOException { while (true) { try { Path filePath = new Path(rootdir, HConstants.CLUSTER_ID_FILE_NAME); return fs.exists(filePath); } catch (IOException ioe) { - if (wait > 0) { - LOG.warn("Unable to check cluster ID file in " + rootdir.toString() + - ", retrying in "+wait+"msec: "+StringUtils.stringifyException(ioe)); + if (wait > 0L) { + LOG.warn("Unable to check cluster ID file in {}, retrying in {}ms", ioe); Review comment: Thanks! ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services