busbey commented on a change in pull request #936: HBASE-17115 Define UI admins
via an ACL
URL: https://github.com/apache/hbase/pull/936#discussion_r357390928
##########
File path:
hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java
##########
@@ -770,30 +777,28 @@ public void addJerseyResourcePackage(final String
packageName,
}
/**
- * Add a servlet in the server.
+ * Adds a servlet in the server that any user can access.
* @param name The name of the servlet (can be passed as null)
* @param pathSpec The path spec for the servlet
* @param clazz The servlet class
*/
- public void addServlet(String name, String pathSpec,
+ public void addUnprivilegedServlet(String name, String pathSpec,
Review comment:
Can we add some brief note here and `addPrivilegedServlet` about how we
should be picking wether a given servlet needs to be restricted?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
