belugabehr commented on issue #934: HBASE-23568: Improve Threading of Replication URL: https://github.com/apache/hbase/pull/934#issuecomment-565519990 Also, after incubating overnight, I do want to make a change. In the `terminate` method, it should loop through the workers stored in the map and signal them to shutdown gracefully. Otherwise, they won't know to shutdown and will be killed eventually by the closing of their threadpool after some delay. I won't be able to make the change until XMas week however. Please leave it for now. On Fri, Dec 13, 2019, 11:53 AM David Mollitor <dam6...@gmail.com> wrote: > Nah. My intention here was not to improve performance, just trying to get > the code "up to code" by using JDK and Guava facilities to better manage > threads. My goal was to untangle the existing setup and to make trouble > shooting and adding capabilities easier later. > > On Fri, Dec 13, 2019, 8:50 AM Sean Busbey <notificati...@github.com> > wrote: > >> Have you gotten to try this out on a cluster? I don't think we have a >> PerfEval equivalent for replication. >> >> — >> You are receiving this because you authored the thread. >> Reply to this email directly, view it on GitHub >> <https://github.com/apache/hbase/pull/934?email_source=notifications&email_token=AC766E3MWR2FQ6QIXR2AJF3QYOHJ5A5CNFSM4J2B5FE2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEG2AYGQ#issuecomment-565447706>, >> or unsubscribe >> <https://github.com/notifications/unsubscribe-auth/AC766E3CGXXB43HTWOVQQQ3QYOHJ5ANCNFSM4J2B5FEQ> >> . >> >
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
