VladRodionov commented on a change in pull request #921: HBASE-22749:
Distributed MOB compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r357852784
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterRpcServices.java
##########
@@ -1749,10 +1747,13 @@ public CompactRegionResponse compactRegion(final
RpcController controller,
master.checkInitialized();
byte[] regionName = request.getRegion().getValue().toByteArray();
TableName tableName = RegionInfo.getTable(regionName);
+ // TODO: support CompactType.MOB
// if the region is a mob region, do the mob file compaction.
if (MobUtils.isMobRegionName(tableName, regionName)) {
checkHFileFormatVersionForMob();
- return compactMob(request, tableName);
+ //TODO: support CompactType.MOB
Review comment:
This is a client - facing feature (CompactType.MOB), currently it is not
handled properly on server-side. I opened ticket to convert call to major
compaction request, user-originated to run MOB compaction. Will work on this
JIRA as soon as I finish your review comments.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
