[ 
https://issues.apache.org/jira/browse/HBASE-23326?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16997870#comment-16997870
 ] 

Michael Stack commented on HBASE-23326:
---------------------------------------

bq. ...so let's isolate it from the normal region store.

Sure. Was suggesting you use a more generic name, do should Master need to 
persist other info, we could group it under a master dir 
(s/MasterProcs/master/).

bq. if we pass a RegionServerServices in...

RSS is an Interface. Was suggesting you pass an impl that only did the subset 
needed to run local Region. I suggest this so local Region looks like any other 
Region in the system.

Yeah, HRegion needs refactoring. Ideally it'd be moved out into its own module. 
Probably have to do hbase-wal module first.

bq. .... if we enable region on master.... 

The WALs are differently named?

IIRC, just moving the WALs into the WALs dir gets them considered by the 
general archiving system; no extra work to be done beyond the move.

bq. ...order is not important....

I suppose if out-of-order, once read into member, the procedures will be 
ordered... .and we won't have odd stuff like seeing a subprocedure before its 
parent (shouldn't matter).

Would be sweet if we could just move the WALs into recovered.edits dir (it is 
named something else as flag to trigger different behavior? OK....).









> Implement a ProcedureStore which stores procedures in a HRegion
> ---------------------------------------------------------------
>
>                 Key: HBASE-23326
>                 URL: https://issues.apache.org/jira/browse/HBASE-23326
>             Project: HBase
>          Issue Type: Improvement
>          Components: proc-v2
>            Reporter: Duo Zhang
>            Assignee: Duo Zhang
>            Priority: Critical
>             Fix For: 3.0.0, 2.3.0
>
>
> So we can resue the code in HRegion for persisting the procedures, and also 
> the optimized WAL implementation for better performance.
> This requires we merge the hbase-procedure module to hbase-server, which is 
> an anti-pattern as we make the hbase-server module more overloaded. But I 
> think later we can first try to move the WAL stuff out.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to