saintstack commented on a change in pull request #956: HBASE-23601:
OutputSink.WriterThread exception gets stuck and repeated indefinietly
URL: https://github.com/apache/hbase/pull/956#discussion_r360487054
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/wal/OutputSink.java
##########
@@ -91,6 +91,15 @@ public synchronized void startWriterThreads() {
}
}
+ public synchronized void restartWriterThreadsIfNeeded() {
+ for (WriterThread t : writerThreads) {
+ if (!t.isAlive()){
+ LOG.debug("restarting thread" + t);
+ t.start();
Review comment:
I didn't think you could restart a dead thread. You have to create a new one?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
