saintstack commented on a change in pull request #968: HBASE-23622 Reduced the number of Checkstyle violations in hbase-common URL: https://github.com/apache/hbase/pull/968#discussion_r361736390
########## File path: hbase-common/src/main/java/org/apache/hadoop/hbase/util/CommonFSUtils.java ########## @@ -821,25 +818,6 @@ public static boolean renameAndSetModifyTime(final FileSystem fs, final Path src return fs.rename(src, dest); } - /** - * Do our short circuit read setup. - * Checks buffer size to use and whether to do checksumming in hbase or hdfs. - * @param conf must not be null - */ - public static void setupShortCircuitRead(final Configuration conf) { Review comment: Not used? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services