virajjasani commented on a change in pull request #939: HBASE-23349 : Config
based Scanner reset after compaction if low refCount is preventing archival of
compacted away store files
URL: https://github.com/apache/hbase/pull/939#discussion_r363105844
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -338,6 +341,7 @@ protected HStore(final HRegion region, final
ColumnFamilyDescriptor family,
getColumnFamilyName(), memstore.getClass().getSimpleName(),
policyName, verifyBulkLoads,
parallelPutCountPrintThreshold, family.getDataBlockEncoding(),
family.getCompressionType());
+ isStoreFileForceArchivalEnabled =
this.conf.getBoolean(FORCE_ARCHIVAL_AFTER_RESET, false);
Review comment:
Sure, we can set this `false` by default as is and let CP set it to true.
Overriding this config value by CP should be taken care of by this line.
Is it good to update the config doc with this info?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
