bharathv commented on issue #994: HBASE-23648: Re-use underlying connection 
registry in RawAsyncHBaseAdmin
URL: https://github.com/apache/hbase/pull/994#issuecomment-571453526
 
 
   > LGTM. Where does it get committed? On branch?
   Yes please, feature branch. It builds on the "ConnectionRegistry" change 
that exists only in the branch. I'm hoping the branch gets merged into the 
master soon.
   
   >For the future, try to minimize your changes. Most of the below is just 
refactoring. Takes a while to verify no accidental breakage. For the future.
   
   Ack. I see your point. Generally I'm trying to fix all the check style 
issues around the places I'm touching, there are tons of violations. But I 
guess it is better to bulk fix them in separate changes.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to