saintstack commented on a change in pull request #995: HBASE-23055 Alter hbase:meta URL: https://github.com/apache/hbase/pull/995#discussion_r364408458
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/RawAsyncHBaseAdmin.java ########## @@ -661,42 +662,54 @@ public void run(PRESP resp) { new DisableTableProcedureBiConsumer(tableName)); } + /** + * Utility for completing passed {@link CompletableFuture} <code>future</code> + * using passed parameters. + */ + private static CompletableFuture<Boolean> completeBoolean(CompletableFuture<Boolean> future, Review comment: Added small test in next push. It was interesting since TestZKRegistry has replicas on meta itself which made things more interesting. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services