busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB compactions URL: https://github.com/apache/hbase/pull/921#discussion_r364966544
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobFileName.java ########## @@ -47,6 +47,7 @@ private Date date; private String dateStr; private byte[] startKey; + private String regionName = "region"; Review comment: Should also have tests for how `hashcode` and `equals` behave in the case where we get a MobFileName that doesn't include a region (e.g. when there are mob hfiles from prior to this patch) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
