Apache9 commented on a change in pull request #1015: HBASE-23668 Master log
start filling with "Flush journal status" messages
URL: https://github.com/apache/hbase/pull/1015#discussion_r365084156
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/procedure2/store/region/RegionFlusherAndCompactor.java
##########
@@ -207,8 +212,14 @@ private void flushLoop() {
}
private boolean shouldFlush(long changes) {
- return region.getMemStoreHeapSize() + region.getMemStoreOffHeapSize() >=
flushSize ||
+ boolean flush = region.getMemStoreHeapSize() +
region.getMemStoreOffHeapSize() >= flushSize ||
changes > flushPerChanges;
+ if (flush && LOG.isTraceEnabled()) {
+ LOG.trace("shouldFlush memStoreSize={}, flushSize={}, changes={},
flushPerChanges={}",
+ region.getMemStoreHeapSize() + region.getMemStoreOffHeapSize(),
flushSize, changes,
Review comment:
These values could change between calls, so I think we'd better store them
in a local variable and then log them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
