bharathv commented on a change in pull request #1020: HBASE-23653 Expose 
content of meta table in web ui
URL: https://github.com/apache/hbase/pull/1020#discussion_r365474032
 
 

 ##########
 File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
 ##########
 @@ -129,6 +151,7 @@
   pageContext.setAttribute("pageTitle", pageTitle);
   AsyncConnection connection = 
ConnectionFactory.createAsyncConnection(master.getConfiguration()).get();
 
 Review comment:
   Not your change, but creating a new connection every time this page loads 
seems a little heavy? Why not reuse the async connection created at the master 
startup? (master.getAsyncConnection()).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to