ndimiduk commented on a change in pull request #1020: HBASE-23653 Expose content of meta table in web ui URL: https://github.com/apache/hbase/pull/1020#discussion_r366463677
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/client/hamcrest/BytesMatchers.java ########## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.client.hamcrest; + +import static org.hamcrest.core.Is.is; Review comment: _is_ is provided by the existing dependency, `hamcrest-core`. I've added the dependency on `hamcrest-library` for the the collection- and bean-related matchers that it provides. This patch makes use of _contains_ and _hasProperty_, but I look forward to writing more tests that make use of others. It's quite unusual to depend only on `hamcrest-core`; usually `-core` and `-library` come as a pair in user applications. I believe `-core` is stand-alone so that 3rd party extension libraries (such as Spotify's [java-hamcrest](https://github.com/spotify/java-hamcrest) can pull in the minimal set if they so choose. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
