joshelser commented on issue #936: HBASE-17115 Define UI admins via an ACL
URL: https://github.com/apache/hbase/pull/936#issuecomment-575793728
 
 
   > I don't see the logs, ... pages listed. Those should be limited to admins 
too?
   
   
https://github.com/apache/hbase/blob/978546b2f247b29dd63bad55b17fdc2e7a31e55d/hbase-http/src/main/java/org/apache/hadoop/hbase/http/HttpServer.java#L681-L683
   
   The logs servlet already had the AdminAuthorizedServlet in the chain; it was 
just ineffective because we weren't configuring/setting an `ADMIN_ACL`.
   
   > I don't see the ... debug, ... pages listed. Those should be limited to 
admins too?
   
   Good catch! Was missing this, will fix.
   
   > I don't see the ... zk dump pages listed. Those should be limited to 
admins too?
   
   I'm not finding this, @busbey . I need to go looking to see if this is a 
branch-specific feature.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to