infraio commented on a change in pull request #1067: HBASE-23156 start-hbase.sh failed with ClassNotFoundException when bu… URL: https://github.com/apache/hbase/pull/1067#discussion_r368262535
########## File path: hbase-assembly/src/main/assembly/hadoop-three-compat.xml ########## @@ -0,0 +1,258 @@ +<?xml version="1.0"?> +<assembly xmlns="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.1"; xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"; xsi:schemaLocation="http://maven.apache.org/plugins/maven-assembly-plugin/assembly/1.1.1 http://maven.apache.org/xsd/assembly-1.1.1.xsd";> +<!-- +/** + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +--> + + <!--This 'all' id is not appended to the produced bundle because we do this: http://maven.apache.org/plugins/maven-assembly-plugin/faq.html#required-classifiers --> + <id>bin</id> + <formats> + <format>tar.gz</format> + </formats> + <componentDescriptors> + <componentDescriptor>src/main/assembly/components.xml</componentDescriptor> + </componentDescriptors> + <moduleSets> + <moduleSet> + <useAllReactorProjects>true</useAllReactorProjects> + <includes> + <!-- Keep this list sorted by name --> + <include>org.apache.hbase:hbase-annotations</include> + <include>org.apache.hbase:hbase-backup</include> + <include>org.apache.hbase:hbase-client</include> + <include>org.apache.hbase:hbase-common</include> + <include>org.apache.hbase:hbase-endpoint</include> + <include>org.apache.hbase:hbase-examples</include> + <include>org.apache.hbase:hbase-external-blockcache</include> + <include>org.apache.hbase:hbase-hadoop-compat</include> + <include>org.apache.hbase:hbase-hadoop2-compat</include> + <include>org.apache.hbase:hbase-http</include> + <include>org.apache.hbase:hbase-it</include> + <include>org.apache.hbase:hbase-mapreduce</include> + <include>org.apache.hbase:hbase-metrics</include> + <include>org.apache.hbase:hbase-metrics-api</include> + <include>org.apache.hbase:hbase-procedure</include> + <include>org.apache.hbase:hbase-protocol</include> + <include>org.apache.hbase:hbase-protocol-shaded</include> + <include>org.apache.hbase:hbase-replication</include> + <include>org.apache.hbase:hbase-rest</include> + <include>org.apache.hbase:hbase-rsgroup</include> + <include>org.apache.hbase:hbase-server</include> + <include>org.apache.hbase:hbase-shell</include> + <include>org.apache.hbase:hbase-testing-util</include> + <include>org.apache.hbase:hbase-thrift</include> + <include>org.apache.hbase:hbase-zookeeper</include> + </includes> + <!-- Binaries for the dependencies also go in the hbase-jars directory --> + <binaries> + <outputDirectory>lib</outputDirectory> + <unpack>false</unpack> + <dependencySets> + <dependencySet> + <excludes> + <!-- Exclude J2EE libraries that get pulled in when building on JDK11 --> + <exclude>com.sun.activation:javax.activation</exclude> + <!-- The following artifacts are transitive dependencies of com.sun.xml.ws:jaxws-ri:pom + They are needed to be included in lib/jdk11 to be added to classpath during + Java 11 runtime hence excluding from main lib. + --> + <exclude>com.sun.xml.ws:*</exclude> + <exclude>jakarta.annotation:jakarta.annotation-api</exclude> + <exclude>org.glassfish.jaxb:*</exclude> + <exclude>com.sun.istack:istack-commons-runtime</exclude> + <exclude>org.glassfish.gmbal:gmbal</exclude> + <exclude>org.glassfish.external:management-api</exclude> + <exclude>org.glassfish.pfl:*</exclude> + <exclude>org.jvnet.staxex:stax-ex</exclude> + <exclude>com.sun.xml.stream.buffer:streambuffer</exclude> + <exclude>org.jvnet.mimepull:mimepull</exclude> + <exclude>com.sun.xml.fastinfoset:FastInfoset</exclude> + <exclude>org.glassfish.ha:ha-api</exclude> + <exclude>com.sun.xml.messaging.saaj:saaj-impl</exclude> Review comment: The key difference is here, remove two jar from the exclude set. <exclude>com.fasterxml.woodstox:woodstox-core</exclude> <exclude>org.codehaus.woodstox:stax2-api</exclude> ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
