HorizonNet commented on a change in pull request #1062: HBASE-23705 Add
CellComparator to HFileContext
URL: https://github.com/apache/hbase/pull/1062#discussion_r368310934
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestHFileReaderImpl.java
##########
@@ -66,9 +65,8 @@ Path makeNewFile() throws IOException {
HFileContext context =
new
HFileContextBuilder().withBlockSize(blocksize).withIncludesTags(true).build();
Configuration conf = TEST_UTIL.getConfiguration();
- HFile.Writer writer =
-
HFile.getWriterFactoryNoCache(conf).withOutputStream(fout).withFileContext(context)
- .withComparator(CellComparatorImpl.COMPARATOR).create();
+ HFile.Writer writer = HFile.getWriterFactoryNoCache(conf).
+ withOutputStream(fout).withFileContext(context).create();
Review comment:
NIT: Most of the time we use a leading `.`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
