[ https://issues.apache.org/jira/browse/HBASE-23683?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17020941#comment-17020941 ]
Wellington Chevreuil commented on HBASE-23683: ---------------------------------------------- Ping [~zghao], I was thinking about cherry-pick this change into branch-2.2. It does change *HBaseInterClusterReplicationEndpoint* by adding two new _protected_ methods, but that doesn't break compatibility. Would think this would be ok to add for the next +*2.2*+ release? > Make HBaseInterClusterReplicationEndpoint more extensible > --------------------------------------------------------- > > Key: HBASE-23683 > URL: https://issues.apache.org/jira/browse/HBASE-23683 > Project: HBase > Issue Type: Improvement > Reporter: Wellington Chevreuil > Assignee: Wellington Chevreuil > Priority: Major > Fix For: 3.0.0, 2.3.0 > > > *HBaseInterClusterReplicationEndpoint* currently creates the cluster > connection and sink manager instances inside its _init_ method and assigns > those to private class variables. Then any potential custom extension of > *HBaseInterClusterReplicationEndpoint* that requires custom implementations > of connection and/or sink manager would need to resort to _java reflection_ > for effectively replace those instances, such as below: > {noformat} > ... > ClusterConnection conn = (ClusterConnection)ConnectionFactory. > createConnection(context.getConfiguration(), > User.create(replicationUgi)); > ReplicationSinkManager sinkManager = new ReplicationSinkManager(conn, > ctx.getPeerId(), > this, context.getConfiguration()); > try { > Field field = this.getClass().getSuperclass().getDeclaredField("conn"); > field.setAccessible(true); > field.set(this, conn); > field = > this.getClass().getSuperclass().getDeclaredField("replicationSinkMgr"); > field.setAccessible(true); > field.set(this, sinkManager); > } catch (Exception e) { > throw new IOException(e); > } > ... > {noformat} -- This message was sent by Atlassian Jira (v8.3.4#803005)