[ https://issues.apache.org/jira/browse/HBASE-20711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17021069#comment-17021069 ]
HBase QA commented on HBASE-20711: ---------------------------------- | (x) *{color:red}-1 overall{color}* | \\ \\ || Vote || Subsystem || Runtime || Comment || | {color:blue}0{color} | {color:blue} reexec {color} | {color:blue} 1m 38s{color} | {color:blue} Docker mode activated. {color} | | {color:red}-1{color} | {color:red} yetus {color} | {color:red} 0m 11s{color} | {color:red} Unprocessed flag(s): --skip-errorprone --quick-hadoopcheck {color} | \\ \\ || Subsystem || Report/Notes || | Docker | Client=19.03.4 Server=19.03.4 base: https://builds.apache.org/job/PreCommit-HBASE-Build/1093/artifact/patchprocess/Dockerfile | | JIRA Issue | HBASE-20711 | | JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12927175/HBASE-20711.branch-2.0.001.patch | | Console output | https://builds.apache.org/job/PreCommit-HBASE-Build/1093/console | | versions | git=2.11.0 | | Powered by | Apache Yetus 0.11.1 https://yetus.apache.org | This message was automatically generated. > Save on a Cell iteration when writing > ------------------------------------- > > Key: HBASE-20711 > URL: https://issues.apache.org/jira/browse/HBASE-20711 > Project: HBase > Issue Type: Bug > Components: Performance > Reporter: Michael Stack > Assignee: Michael Stack > Priority: Minor > Attachments: HBASE-20711.branch-2.0.001.patch > > > This is a minor savings. We were doing a spin through all Cells on receipt > just to check their size when subsequently, we were doing an iteration of all > Cells to insert. It manifest as a little spike in perf output. This change > removes the purposed spin through Cells and just does size check as part of > the general Cell insert (perf spike no longer shows but the cost of the size > check still remains). > There is also a minor bug fix where on receipt we were using the Puts row > rather than the Cells row; client may have succeeded in submitting a Cell > that disagreed with the hosting Mutation and it would have been written as > something else altogether -- with the Puts row -- rather than being rejected. -- This message was sent by Atlassian Jira (v8.3.4#803005)