saintstack commented on a change in pull request #1091: HBASE-23731: De-flake
TestFromClientSide
URL: https://github.com/apache/hbase/pull/1091#discussion_r371068889
##########
File path:
hbase-common/src/test/java/org/apache/hadoop/hbase/HBaseClassTestRule.java
##########
@@ -82,6 +99,49 @@ private static long getTimeoutInSeconds(Class<?> clazz) {
clazz.getName() + " does not have SmallTests/MediumTests/LargeTests in
@Category");
}
+ /**
+ * @param clazz Test class that is running.
+ * @return the number of parameters for this given test class. If the test
is not parameterized or
+ * if there is any issue determining the number of parameters, returns 1.
+ */
+ private static int getNumParameters(Class<?> clazz) {
+ RunWith[] runWiths = clazz.getAnnotationsByType(RunWith.class);
+ boolean isTestParameterized = runWiths != null &&
Arrays.stream(runWiths).anyMatch(
Review comment:
FYI, isTestParameterized is name of a method, not a variable.
testParameterized would be the variable name.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
