[
https://issues.apache.org/jira/browse/HBASE-21902?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17024581#comment-17024581
]
Xu Cang edited comment on HBASE-21902 at 1/27/20 7:07 PM:
----------------------------------------------------------
Hi [~dcz99] thanks for working on this JIRA. Please see this doc how to submit
patch correctly. [https://hbase.apache.org/book.html#developing]
And by looking at your patch, if you think NoOpScanPolicyObserver is not
instantiated, why does throwing the RuntimeException in that class help?
thanks.
was (Author: xucang):
Hi [~dcz99] thanks for working on this JIRA. Please see this doc how to submit
patch correctly. [https://hbase.apache.org/book.html#developing]
> TestCompactionWithCoprocessor doesn't invoke coprocessor logic
> --------------------------------------------------------------
>
> Key: HBASE-21902
> URL: https://issues.apache.org/jira/browse/HBASE-21902
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 2.0.4
> Reporter: david zhang
> Priority: Minor
> Attachments: hbase-test.patch
>
>
> TestCompactionWithCoprocessor is designed to invoke NoOpScanPolicyObserver
> which implements default behavior. in reality NoOpScanPolicyObserver isn't
> instantiated, TestCompactionWithCoprocessor runs/passes trivially, without
> increasing test coverage beyond TestCompaction.
> See patch which passes TestCompactionWithCoprocessor.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
