busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r375536023
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -326,47 +493,113 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
progress.cancel();
throw new InterruptedIOException(
"Interrupted while control throughput of compacting " +
compactionName);
+ } catch (IOException t) {
+ String msg = "Mob compaction failed for region: " +
+ store.getRegionInfo().getEncodedName();
+ throw new IOException(msg, t);
} finally {
// Clone last cell in the final because writer will append last cell
when committing. If
// don't clone here and once the scanner get closed, then the memory of
last cell will be
// released. (HBASE-22582)
((ShipperListener) writer).beforeShipped();
throughputController.finish(compactionName);
if (!finished && mobFileWriter != null) {
+ // Remove all MOB references because compaction failed
+ mobRefSet.get().clear();
+ // Abort writer
+ LOG.debug("Aborting writer for {} because of a compaction failure,
Store {}",
+ mobFileWriter.getPath(), getStoreInfo());
abortWriter(mobFileWriter);
}
- if (!finished && delFileWriter != null) {
- abortWriter(delFileWriter);
- }
}
- if (delFileWriter != null) {
- if (deleteMarkersCount > 0) {
- // If the del file is not empty, commit it.
- // If the commit fails, the compaction is re-performed again.
- delFileWriter.appendMetadata(fd.maxSeqId, major, deleteMarkersCount);
- delFileWriter.close();
- mobStore.commitFile(delFileWriter.getPath(), path);
- } else {
- // If the del file is empty, delete it instead of committing.
- abortWriter(delFileWriter);
- }
+
+ // Commit last MOB writer
+ commitOrAbortMobWriter(mobFileWriter, fd.maxSeqId, mobCells, major);
+ mobStore.updateCellsCountCompactedFromMob(cellsCountCompactedFromMob);
+ mobStore.updateCellsCountCompactedToMob(cellsCountCompactedToMob);
+ mobStore.updateCellsSizeCompactedFromMob(cellsSizeCompactedFromMob);
+ mobStore.updateCellsSizeCompactedToMob(cellsSizeCompactedToMob);
+ progress.complete();
+ return true;
+ }
+
+ private String getStoreInfo() {
+ return String.format("[table=%s family=%s region=%s]",
store.getTableName().getNameAsString(),
+ store.getColumnFamilyName(), store.getRegionInfo().getEncodedName()) ;
+ }
+
+ private void clearThreadLocals() {
+ Set<String> set = mobRefSet.get();
+ if (set != null) {
+ set.clear();
}
+ HashMap<String, Long> map = mobLengthMap.get();
+ if (map != null) {
+ map.clear();
+ }
+ }
+
+ private StoreFileWriter newMobWriter(FileDetails fd)
+ throws IOException {
+ try {
+ StoreFileWriter mobFileWriter = mobStore.createWriterInTmp(new
Date(fd.latestPutTs),
+ fd.maxKeyCount, compactionCompression,
store.getRegionInfo().getStartKey(), true);
+ LOG.debug("New MOB writer created={}",
mobFileWriter.getPath().getName());
Review comment:
include the store info here
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
