busbey commented on a change in pull request #921: HBASE-22749: Distributed MOB
compactions
URL: https://github.com/apache/hbase/pull/921#discussion_r375506309
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/mob/DefaultMobStoreCompactor.java
##########
@@ -169,6 +241,22 @@ protected boolean performCompaction(FileDetails fd,
InternalScanner scanner, Cel
long bytesWrittenProgressForCloseCheck = 0;
long bytesWrittenProgressForLog = 0;
long bytesWrittenProgressForShippedCall = 0;
+ // Clear old mob references
+ mobRefSet.get().clear();
+ boolean isUserRequest = userRequest.get();
+ boolean compactMOBs = major && isUserRequest;
+ boolean discardMobMiss =
conf.getBoolean(MobConstants.MOB_UNSAFE_DISCARD_MISS_KEY,
+ MobConstants.DEFAULT_MOB_DISCARD_MISS);
+ if (discardMobMiss) {
+ LOG.warn("{}=true. This is unsafe setting recommended only"+
+ " during upgrade process from MOB 1.0 to MOB 2.0 versions.",
Review comment:
Please don't refer to MOB version numbers, since they haven't been used
consistently in the project. refer to the specific feature that necessitates
using the key. e.g. "only when first upgrading to a version with the
distributed mob compaction feature on a cluster that has experienced MOB data
corruption."
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
